Messages in this thread | | | Date | Fri, 17 Jun 2011 02:42:13 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH] ACPI, APEI, Add APEI _OSC support |
| |
On Fri, Jun 17, 2011 at 09:40:17AM +0800, Huang Ying wrote: > On 06/17/2011 09:34 AM, Matthew Garrett wrote: > > If the kernel has been configured with support for the feature then I > > think we ought to be able to assume that the kernel will support it at > > runtime. > > There may be error during driver initialization. That is what I am > concerned.
That's true of any _OSC functionality.
> >> So I think we can do that in 2 steps. At first, we just enable WHEA > >> UUID, because that is easier to do. Then we find a way to implement > >> "APEI bit" in generic _OSC call. Do you think that is a good idea? > > > > I'm fine with that, providing that GHES isn't disabled purely because > > the WHEA UUID call wasn't successful. > > Because we have not added the code to make generic _OSC call with "APEI > bit" now, so if WHEA UUID call failed, we have no firmware first mode > enabled. So I think it is safe to disable GHES if WHEA UUID call > failed. But in another hand, keeping GHES has no harm too. So I am OK > to keep GHES if WHEA UUID call failed.
I see your point. But this does need to be fixed in the long run.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |