lkml.org 
[lkml]   [2011]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 70/77] Staging: hv: netvsc: Cleanup error return values in rndis_filter_set_packet_filter()
    Date
    Use standard Linux error codes and cleanup some error paths.

    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
    Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
    ---
    drivers/staging/hv/rndis_filter.c | 5 +----
    1 files changed, 1 insertions(+), 4 deletions(-)

    diff --git a/drivers/staging/hv/rndis_filter.c b/drivers/staging/hv/rndis_filter.c
    index f26886d..f5f3052 100644
    --- a/drivers/staging/hv/rndis_filter.c
    +++ b/drivers/staging/hv/rndis_filter.c
    @@ -511,7 +511,7 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev,
    RNDIS_MESSAGE_SIZE(struct rndis_set_request) +
    sizeof(u32));
    if (!request) {
    - ret = -1;
    + ret = -ENOMEM;
    goto Cleanup;
    }

    @@ -531,7 +531,6 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev,
    t = wait_for_completion_timeout(&request->wait_event, 5*HZ);

    if (t == 0) {
    - ret = -1;
    dev_err(&dev->net_dev->dev->device,
    "timeout before we got a set response...\n");
    /*
    @@ -540,8 +539,6 @@ static int rndis_filter_set_packet_filter(struct rndis_device *dev,
    */
    goto Exit;
    } else {
    - if (ret > 0)
    - ret = 0;
    set_complete = &request->response_msg.msg.set_complete;
    status = set_complete->status;
    }
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-06-16 22:07    [W:0.019 / U:0.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site