Messages in this thread | | | Date | Thu, 16 Jun 2011 16:19:30 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 01/11] drivers/ide: use printk_ratelimited() instead of printk_ratelimit() |
| |
On Thu, Jun 16, 2011 at 02:06:37PM +0200, Manuel Zerpies wrote: > Since printk_ratelimit() shouldn't be used anymore (see comment in > include/linux/printk.h), replace it with printk_ratelimited(). > > Signed-off-by: Manuel Zerpies <manuel.f.zerpies@ww.stud.uni-erlangen.de> > --- > drivers/ide/ide-atapi.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c > index 6f218e01..1b04f45 100644 > --- a/drivers/ide/ide-atapi.c > +++ b/drivers/ide/ide-atapi.c > @@ -8,6 +8,7 @@ > #include <linux/ide.h> > #include <linux/scatterlist.h> > #include <linux/gfp.h> > +#include <linux/ratelimit.h> > > #include <scsi/scsi.h> > > @@ -200,8 +201,7 @@ void ide_prep_sense(ide_drive_t *drive, struct request *rq) > err = blk_rq_map_kern(drive->queue, sense_rq, sense, sense_len, > GFP_NOIO); > if (unlikely(err)) { > - if (printk_ratelimit()) > - printk(KERN_WARNING PFX "%s: failed to map sense " > + printk_ratelimited(KERN_WARNING PFX "%s: failed to map sense " > "buffer\n", drive->name);
Does the printk fit on one line if you do
pr_warn_ratelimited(...)
instead?
Thanks.
-- Regards/Gruss, Boris.
| |