[lkml]   [2011]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/3] [RFC] genhd: add a new attribute in device structure
    Hi Greg,

    (2011/06/16 0:33), Greg KH wrote:
    > On Wed, Jun 15, 2011 at 05:16:28PM +0900, Nao Nishijima wrote:
    >> Allow users to set the preferred name of device via sysfs interface.
    >> (Exsample) sda -> foo
    >> # echo foo > /sys/block/sda/preferred_name
    >> Suggested-by: James Bottomley <>
    >> Suggested-by: Jon Masters <>
    >> Signed-off-by: Nao Nishijima <>
    > You don't document this new sysfs file (which is required), nor do you
    > explain what it is for and how to use it.
    > Please do that in this patch, and in a Documentation/ABI/ file for any
    > new sysfs file you create.

    I'm afraid that my explanation was not enough.
    I will add explanation to this patch and Documentation/ABI file.

    > I still fail to understand how a "preferred" file will help anyone out
    > here at all...

    Let me explain, users cannot identify a device from a device name
    because device names may change at each boot up time. If kernel show
    preferred names in kernel messages, users can easily identify a device
    from kernel messages.

    > greg k-h


    Software Platform Research Dept. Linux Technology Center
    Hitachi, Ltd., YOKOHAMA Research Laboratory
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-06-16 14:07    [W:0.022 / U:3.436 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site