Messages in this thread |  | | | Date | Thu, 16 Jun 2011 21:03:43 +0900 | | From | Nao Nishijima <> | | Subject | Re: [PATCH 1/3] [RFC] genhd: add a new attribute in device structure |
| |
Hi Greg,
(2011/06/16 0:33), Greg KH wrote: > On Wed, Jun 15, 2011 at 05:16:28PM +0900, Nao Nishijima wrote: >> Allow users to set the preferred name of device via sysfs interface. >> >> (Exsample) sda -> foo >> # echo foo > /sys/block/sda/preferred_name >> >> Suggested-by: James Bottomley <James.Bottomley@HansenPartnership.com> >> Suggested-by: Jon Masters <jcm@redhat.com> >> Signed-off-by: Nao Nishijima <nao.nishijima.xt@hitachi.com> > > You don't document this new sysfs file (which is required), nor do you > explain what it is for and how to use it. > > Please do that in this patch, and in a Documentation/ABI/ file for any > new sysfs file you create. >
I'm afraid that my explanation was not enough. I will add explanation to this patch and Documentation/ABI file.
> I still fail to understand how a "preferred" file will help anyone out > here at all... >
Let me explain, users cannot identify a device from a device name because device names may change at each boot up time. If kernel show preferred names in kernel messages, users can easily identify a device from kernel messages.
> greg k-h >
Thanks,
-- Nao NISHIJIMA Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., YOKOHAMA Research Laboratory Email: nao.nishijima.xt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |