lkml.org 
[lkml]   [2011]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH/Trivial] docproc: cleanup brace placement
    The placement of the opening brace "{" after 'if' statements in 
    scripts/docproc.c is inconsistent. Most are placed on the same line as the
    'if' statement itself as per CodingStyle, but a few are not.
    This patch cleans up the inconsistency. We save a few source lines and the
    file then uses the same style throughout, which is nice.

    Signed-off-by: Jesper Juhl <jj@chaosbits.net>
    ---
    docproc.c | 17 +++++------------
    1 file changed, 5 insertions(+), 12 deletions(-)

    diff --git a/scripts/docproc.c b/scripts/docproc.c
    index 98dec87..4cfdc17 100644
    --- a/scripts/docproc.c
    +++ b/scripts/docproc.c
    @@ -205,8 +205,7 @@ static void find_export_symbols(char * filename)
    PATH_MAX - strlen(real_filename));
    sym = add_new_file(filename);
    fp = fopen(real_filename, "r");
    - if (fp == NULL)
    - {
    + if (fp == NULL) {
    fprintf(stderr, "docproc: ");
    perror(real_filename);
    exit(1);
    @@ -487,8 +486,7 @@ static void parse_file(FILE *infile)
    default:
    defaultline(line);
    }
    - }
    - else {
    + } else {
    defaultline(line);
    }
    }
    @@ -519,8 +517,7 @@ int main(int argc, char *argv[])
    exit(2);
    }

    - if (strcmp("doc", argv[1]) == 0)
    - {
    + if (strcmp("doc", argv[1]) == 0) {
    /* Need to do this in two passes.
    * First pass is used to collect all symbols exported
    * in the various files;
    @@ -556,9 +553,7 @@ int main(int argc, char *argv[])
    fprintf(stderr, "Warning: didn't use docs for %s\n",
    all_list[i]);
    }
    - }
    - else if (strcmp("depend", argv[1]) == 0)
    - {
    + } else if (strcmp("depend", argv[1]) == 0) {
    /* Create first part of dependency chain
    * file.tmpl */
    printf("%s\t", argv[2]);
    @@ -571,9 +566,7 @@ int main(int argc, char *argv[])
    findall = adddep;
    parse_file(infile);
    printf("\n");
    - }
    - else
    - {
    + } else {
    fprintf(stderr, "Unknown option: %s\n", argv[1]);
    exit(1);
    }

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2011-06-15 12:03    [W:4.615 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site