| Subject | Re: [PATCH v4 3.0-rc2-tip 7/22] 7: uprobes: mmap and fork hooks. | From | Peter Zijlstra <> | Date | Wed, 15 Jun 2011 20:11:26 +0200 |
| |
On Tue, 2011-06-07 at 18:29 +0530, Srikar Dronamraju wrote: > + up_write(&mm->mmap_sem); > + mutex_lock(&uprobes_mutex); > + down_read(&mm->mmap_sem);
egads, and all that without a comment explaining why you think that is even remotely sane.
I'm not at all convinced, it would expose the mmap() even though you could still decide to tear it down if this function were to fail, I bet there's some funnies there.
|