Messages in this thread |  | | | Date | Wed, 15 Jun 2011 11:05:24 -0500 | | From | Greg Dietsche <> | | Subject | Re: [Cocci] Re: [PATCH v2] coccinelle: if (ret) return ret; return ret; semantic patch |
| |
On Wed, Jun 15, 2011 at 05:35:47PM +0200, Julia Lawall wrote: > > except that 4 of the 5 ORs are cases where we want to do the -return ret; + > > return ret; So I suppose for performance, I should actually add the +/- to > > each of the 4 cases that we want cocci to generate a patch for? > > Actually, it's probably not that big a deal. It's only rewriting the ones > where there is a return ret just before, not all the returns in the code, > like I was originally thinking.
Ok :) I'll update the patch one last time - hopefully we've got everything nailed down now :)
thanks for being so incredibly helpful!
Greg
> > julia >
|  |