lkml.org 
[lkml]   [2011]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 5/5] GPIO: pca953x.c: Fix warning of enabled interrupts in handler
    Date
    When using nested threaded irqs, use handle_nested_irq(). This function
    does not call the chip handler, so no handler is set.

    Signed-off-by: David Jander <david@protonic.nl>
    ---
    drivers/gpio/pca953x.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
    index 9bdbc16..2eceb2c 100644
    --- a/drivers/gpio/pca953x.c
    +++ b/drivers/gpio/pca953x.c
    @@ -435,7 +435,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)

    do {
    level = __ffs(pending);
    - generic_handle_irq(level + chip->irq_base);
    + handle_nested_irq(level + chip->irq_base);

    pending &= ~(1 << level);
    } while (pending);
    @@ -483,8 +483,8 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,

    irq_clear_status_flags(irq, IRQ_NOREQUEST);
    irq_set_chip_data(irq, chip);
    - irq_set_chip_and_handler(irq, &pca953x_irq_chip,
    - handle_simple_irq);
    + irq_set_chip(irq, &pca953x_irq_chip);
    + irq_set_nested_thread(irq, true);
    #ifdef CONFIG_ARM
    set_irq_flags(irq, IRQF_VALID);
    #else
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-06-14 11:03    [W:0.023 / U:30.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site