Messages in this thread | | | Date | Tue, 14 Jun 2011 16:29:59 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v4 3.0-rc2-tip 4/22] 4: Uprobes: register/unregister probes. |
| |
On 06/14, Srikar Dronamraju wrote: > > * Oleg Nesterov <oleg@redhat.com> [2011-06-13 21:57:01]: > > > > + mutex_lock(&mapping->i_mmap_mutex); > > > + vma_prio_tree_foreach(vma, &iter, &mapping->i_mmap, 0, 0) { > > > > I didn't actually read this patch yet, but this looks suspicious. > > Why begin == end == 0? Doesn't this mean we are ignoring the mappings > > with vm_pgoff != 0 ? > > > > Perhaps this should be offset >> PAGE_SIZE? > > > > Okay, > I guess you meant something like this. > > vma_prio_tree_foreach(vma, &iter, &mapping->i_mmap, pgoff, pgoff) { > > where pgoff == offset >> PAGE_SIZE > Right?
Yes, modulo s/PAGE_SIZE/PAGE_SHIFT. But please double check, I can be easily wrong ;)
Oleg.
| |