lkml.org 
[lkml]   [2011]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver
    From
    Date
    Hi,
    -- cut--
    > > +
    > > +static int __init ssi_init(void)
    > > +{
    > > + return platform_device_register(&ssi_pdev);
    > > +}
    > > +subsys_initcall(ssi_init);
    >
    > Looks like you need something here also to prevent this subsys_initcall
    > on running on all boards. Maybe have a pointer to ssi_pdev that only
    > gets initialized after omap_ssi_config?
    >
    > Then you can have ssi_init fail if no configuration is called:
    >
    > if (!pdev)
    > return -ENODEV;
    >
    > return platform_device_register(pdev);
    >

    Right. I'll do those changes.

    Thanks,
    Carlos



    \
     
     \ /
      Last update: 2011-06-14 14:15    [W:0.020 / U:120.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site