lkml.org 
[lkml]   [2011]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/15] tracing: Add a free on close control mechanism for buffer_size_kb

    * Steven Rostedt <rostedt@goodmis.org> wrote:

    > + switch (cmd) {
    > + case TRACE_RINGBUF_FREE_ON_CLOSE: {
    > + info->free_buffer_on_close = !!arg;
    > + ret = 0;
    > + break;
    > + }
    > }

    that doesn't look very tidy.

    > @@ -3635,9 +3700,12 @@ static const struct file_operations tracing_pipe_fops = {
    > };
    >
    > static const struct file_operations tracing_entries_fops = {
    > - .open = tracing_open_generic,
    > + .open = tracing_entries_open,
    > .read = tracing_entries_read,
    > .write = tracing_entries_write,
    > + .unlocked_ioctl = tracing_entries_ioctl,
    > + .compat_ioctl = tracing_entries_ioctl,

    i don't like it at all that you are adding to the ftrace ABI here.
    The *only* premise of the whole /debug/tracing/ muck was to allow it
    to be human-parseable and scripted - an ioctl is clearly outside that
    scope. Instead of increasing the mess in /debug/tracing/ we want
    clean tracing done via the perf ABI ...

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2011-06-13 12:15    [W:4.028 / U:0.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site