| Date | Mon, 13 Jun 2011 12:09:18 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 02/15] tracing: Use NUMA allocation for per-cpu ring buffer pages |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> for (i = 0; i < nr_pages; i++) { > + struct page *page; > bpage = kzalloc_node(ALIGN(sizeof(*bpage), cache_line_size()),
missing separation between local variable definitions and the first C statement.
Same mistake repeats elsewhere in the patch as well.
> + page = alloc_pages_node(cpu_to_node(cpu), GFP_KERNEL, > + 0);
that linebreak is pointless.
> + info->spare = ring_buffer_alloc_read_page(info->tr->buffer, > + info->cpu);
ditto.
Thanks,
Ingo
|