lkml.org 
[lkml]   [2011]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/15] tracing: Use NUMA allocation for per-cpu ring buffer pages

    * Steven Rostedt <rostedt@goodmis.org> wrote:

    > for (i = 0; i < nr_pages; i++) {
    > + struct page *page;
    > bpage = kzalloc_node(ALIGN(sizeof(*bpage), cache_line_size()),

    missing separation between local variable definitions and the first C
    statement.

    Same mistake repeats elsewhere in the patch as well.

    > + page = alloc_pages_node(cpu_to_node(cpu), GFP_KERNEL,
    > + 0);

    that linebreak is pointless.

    > + info->spare = ring_buffer_alloc_read_page(info->tr->buffer,
    > + info->cpu);

    ditto.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2011-06-13 12:11    [W:0.020 / U:11.748 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site