lkml.org 
[lkml]   [2011]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] unicore32, exec: remove redundant set_fs(USER_DS)
From
Date
On Fri, 2011-06-10 at 15:11 +0200, Mathias Krause wrote:
> The address limit is already set in flush_old_exec() so this
> set_fs(USER_DS) is redundant.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
> arch/unicore32/include/asm/processor.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/unicore32/include/asm/processor.h b/arch/unicore32/include/asm/processor.h
> index e11cb07..f0d780a 100644
> --- a/arch/unicore32/include/asm/processor.h
> +++ b/arch/unicore32/include/asm/processor.h
> @@ -53,7 +53,6 @@ struct thread_struct {
> #define start_thread(regs, pc, sp) \
> ({ \
> unsigned long *stack = (unsigned long *)sp; \
> - set_fs(USER_DS); \
> memset(regs->uregs, 0, sizeof(regs->uregs)); \
> regs->UCreg_asr = USER_MODE; \
> regs->UCreg_pc = pc & ~1; /* pc */ \

Hi Mathias,
I searched for the code in flush_old_exec(), but I can't find the code
you mentioned. Could you make it more clear?
And, if all fs codes (not only elf and aout) have the similar
implementations, perhaps all arch-specific codes should be manipulated
in the meanwhile.

Also Cc: Arnd Bergmann <arnd@arndb.de>

Thanks & Regards.

Guan Xuetao



\
 
 \ /
  Last update: 2011-06-13 11:21    [W:0.236 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site