[lkml]   [2011]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] usb:gadget: use min_t() macro instead of min()

    On Mon, Jun 13, 2011 at 03:03:44PM -0400, Alan Stern wrote:
    > > > The change I suggested involved replacing two typecasts with a single
    > > > min_t. All (or almost all) the places this patch touches currently
    > > > contain only one typecast, so the motivation for changing them is a lot
    > > > weaker.
    > > >
    > > You're right. So what's the final call on this one? Do you think it can be
    > > merged or you prefer not change anything? I personally think the code looks
    > > nicer using min_t instead of min with casting but that's just my opinion and
    > > of course there are arguments against this patch.
    > I don't care either way. It's up to you and Felipe.

    I guess it's better to have a more critical look at the arguments first.
    Looking into dummy_hcd for instance, it doesn't appear like we need to
    be int, it could be unsigned int. I just skimmed through the code, but
    it looks like we will always hold >= 0 values on that variable.

    So go through that exercise first, then we look at the others. Blindly
    changing to min_t() might not give us any improvements at all ;-)

    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2011-06-13 21:11    [W:0.032 / U:36.396 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site