Messages in this thread | | | Subject | Re: [PATCH v4 3.0-rc2-tip 4/22] 4: Uprobes: register/unregister probes. | From | Steven Rostedt <> | Date | Mon, 13 Jun 2011 12:50:19 -0400 |
| |
On Fri, 2011-06-10 at 01:03 +0200, Peter Zijlstra wrote:
> The comment in del_consumer() that says: 'drop creation ref' worries me > and makes me thing that is the last reference around and the uprobe will > be freed right there, which clearly cannot happen since its not yet > removed from the RB-tree.
I agree about that comment. It scared me too, not only about the RB tree, but the uprobe is used later in that function to drop the write_rwsem.
I think that comment needs to be changed to something like:
/* Have caller drop the creation ref */
-- Steve
| |