Messages in this thread |  | | | Date | Mon, 13 Jun 2011 23:48:53 +0900 | | From | Minchan Kim <> | | Subject | Re: [PATCH v3 01/10] compaction: trivial clean up acct_isolated |
| |
On Sun, Jun 12, 2011 at 04:24:05PM +0200, Michal Hocko wrote: > On Tue 07-06-11 23:38:14, Minchan Kim wrote: > > acct_isolated of compaction uses page_lru_base_type which returns only > > base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE. > > In addtion, cc->nr_[anon|file] is used in only acct_isolated so it doesn't have > > fields in conpact_control. > > This patch removes fields from compact_control and makes clear function of > > acct_issolated which counts the number of anon|file pages isolated. > > > > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > Cc: Mel Gorman <mgorman@suse.de> > > Cc: Andrea Arcangeli <aarcange@redhat.com> > > Acked-by: Rik van Riel <riel@redhat.com> > > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Signed-off-by: Minchan Kim <minchan.kim@gmail.com> > > Sorry for the late reply. I have looked at the previous posting but
No problem. Thanks for the review, Michal.
> didn't have time to comment on it. > > Yes, stack usage reduction makes sense and the function also looks more > compact. > > Reviewed-by: Michal Hocko <mhocko@suse.cz> >
-- Kind regards, Minchan Kim
|  |