lkml.org 
[lkml]   [2011]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drivers/bluetooth/bpa10x.c: missing kfrees
    Date
    both bpa10x_submit_initr_urb() and bpa10x_submit_bulk_urb()
    malloc a char buffer(buf) for usb_fill_init_usb() but fail to
    free it after freeing the urb.

    Likewise, bpa10x_send_frame() allocates a usb_ctrlrequest(dr)
    for sending packets but does not free it after the
    usb_fill_control_urb() call.

    Signed-off-by: Connor Hansen <cmdkhh@gmail.com>
    ---
    drivers/bluetooth/bpa10x.c | 3 +++
    1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c
    index 751b338..7dfd9ca 100644
    --- a/drivers/bluetooth/bpa10x.c
    +++ b/drivers/bluetooth/bpa10x.c
    @@ -254,6 +254,7 @@ static inline int bpa10x_submit_intr_urb(struct hci_dev *hdev)
    }

    usb_free_urb(urb);
    + kfree(buf);

    return err;
    }
    @@ -295,6 +296,7 @@ static inline int bpa10x_submit_bulk_urb(struct hci_dev *hdev)
    }

    usb_free_urb(urb);
    + kfree(buf);

    return err;
    }
    @@ -393,6 +395,7 @@ static int bpa10x_send_frame(struct sk_buff *skb)
    skb->data, skb->len, bpa10x_tx_complete, skb);

    hdev->stat.cmd_tx++;
    + kfree(df);
    break;

    case HCI_ACLDATA_PKT:
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-06-11 23:25    [W:0.021 / U:0.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site