Messages in this thread | | | Date | Sat, 11 Jun 2011 08:47:51 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static |
| |
On Fri, Jun 10, 2011 at 03:15:05PM -0700, H Hartley Sweeten wrote: > The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver > and should be marked static. > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Mika Westerberg <mika.westerberg@iki.fi>
> Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vinod.koul@intel.com> > > --- > > diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c > index 0766c1e..5d7a49b 100644 > --- a/drivers/dma/ep93xx_dma.c > +++ b/drivers/dma/ep93xx_dma.c > @@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan) > * > * Returns a valid DMA descriptor or %NULL in case of failure. > */ > -struct dma_async_tx_descriptor * > +static struct dma_async_tx_descriptor * > ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, > dma_addr_t src, size_t len, unsigned long flags) > {
| |