lkml.org 
[lkml]   [2011]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRe: [PATCH] m68k: Patch for broken lsl64() "old code" with incorrect shift
On Sat, Jun 11, 2011 at 8:01 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> I think it's better to just remove all #ifdefed out parts in the code.

I'm good either way, as long as the broken "old code" is no longer present.

> The patch is reversed?

My apologies, you're correct. In case anyone is interested in the
correct patch:

Signed-off-by: Jonathan Elchison <jelchison@gmail.com>

-----------------------------------------------------------------
diff -up linux-2.6_orig/arch/m68k/math-emu/multi_arith.h
linux-2.6/arch/m68k/math-emu/multi_arith.h
--- linux-2.6_orig/arch/m68k/math-emu/multi_arith.h 2011-06-10
22:47:43.407285452 -0400
+++ linux-2.6/arch/m68k/math-emu/multi_arith.h 2011-06-10
22:50:32.538711320 -0400
@@ -236,7 +236,7 @@ static inline void lsl64(int count, unsi
{
if (count < 32) {
HI_WORD(*dest) = (HI_WORD(*dest) << count)
- | (LO_WORD(*dest) >> count);
+ | (LO_WORD(*dest) >> (32 - count));
LO_WORD(*dest) <<= count;
return;
}
-----------------------------------------------------------------
Please personally CC me on responses to this post.

v/r,

--
Jonathan Elchison
jelchison@gmail.com


\
 
 \ /
  Last update: 2011-06-11 14:37    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site