lkml.org 
[lkml]   [2011]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/9] x86/amd-iommu: Search for existind dev_data before allocting a new one
    * Joerg Roedel (joerg.roedel@amd.com) wrote:
    > +static struct iommu_dev_data *search_dev_data(u16 devid)
    > +{
    > + struct iommu_dev_data *dev_data;
    > + unsigned long flags;
    > +
    > + spin_lock_irqsave(&dev_data_list_lock, flags);
    > + list_for_each_entry(dev_data, &dev_data_list, dev_data_list) {
    > + if (dev_data->devid == devid)

    This devid match on a global list is not going to work in a multi-segment
    machine. I guess non-zero segment function would either not exist or go
    through swiotlb since it's not supported by hw def'n, so only a concern
    for the future (along with the other devid based lookup tables).

    thanks,
    -chris


    \
     
     \ /
      Last update: 2011-06-10 22:55    [W:0.021 / U:30.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site