lkml.org 
[lkml]   [2011]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 04/10] MCE: Move ADDR/MISC reading code into common function
    From
    On Fri, Jun 10, 2011 at 2:33 AM, Borislav Petkov <bp@amd64.org> wrote:
    >> Used for next patch.
    >
    > Yeah, let's have a more general comment here like "save us some code
    > duplication"

    Sure.

    >> +/*
    >> + * Read ADDR and MISC registers.
    >> + */
    >
    > No need for that comment, IMO. Function is small enough and the macros
    > speak for themselves :).

    Ok.

    >> +static void mce_read_aux(struct mce *m, int i)
    >
    > inline?

    Compiler will possibly do this anyway - I hate to second guess it. I'm not a
    big fan of inline for code that isn't in the critical performance path.

    -Tony


    \
     
     \ /
      Last update: 2011-06-10 20:21    [W:0.024 / U:0.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site