lkml.org 
[lkml]   [2011]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] sony_ff_hid_descriptor
    On Mon, 23 May 2011 03:19:58 -0700
    Simon Wood <simon@mungewell.org> wrote:

    > This patch modifies the HID descriptor to allow the reporting of
    > the accelerometers and gyro via a joystick axis.

    I am going to test it tomorrow, but for now I notice that the
    Signed-off-by is missing. Wait for the test before resending tho.

    Plus, the short commit message can be improved a little bit, and the
    long commit message could use the classic imperative form used in kernel
    commit messages: "Modify the HID descriptor to...", but these are just
    suggestions.

    Same comments for patch 2/2.

    Thanks,
    Antonio

    > ---
    > drivers/hid/hid-sony.c | 11 +++++++++++
    > 1 files changed, 11 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
    > index 936c911..5c930dc 100644
    > --- a/drivers/hid/hid-sony.c
    > +++ b/drivers/hid/hid-sony.c
    > @@ -28,6 +28,12 @@
    > #define SIXAXIS_CONTROLLER_USB (1 << 1)
    > #define SIXAXIS_CONTROLLER_BT (1 << 2)
    >
    > +static const u8 sixaxis_rdesc_fixup[] = {
    > + 0x95, 0x13, 0x09, 0x01, 0x81, 0x02, 0x95, 0x0C,
    > + 0x81, 0x01, 0x75, 0x10, 0x95, 0x04, 0x26, 0xFF,
    > + 0x03, 0x46, 0xFF, 0x03, 0x09, 0x01, 0x81, 0x02
    > + };
    > +
    > struct sony_sc {
    > unsigned long quirks;
    > };
    > @@ -43,6 +49,11 @@ static __u8 *sony_report_fixup(struct hid_device *hdev, __u8 *rdesc,
    > hid_info(hdev, "Fixing up Sony Vaio VGX report descriptor\n");
    > rdesc[55] = 0x06;
    > }
    > + if ((sc->quirks & SIXAXIS_CONTROLLER_USB) &&
    > + *rsize == 148 && rdesc[83] == 0x75) {
    > + hid_info(hdev, "Fixing up Sony Sixaxis report descriptor\n");
    > + memcpy((void *)&rdesc[83], (void *) &sixaxis_rdesc_fixup, sizeof(sixaxis_rdesc_fixup));
    > + }
    > return rdesc;
    > }
    >
    > --
    > 1.7.4.1
    >
    >

    --
    Antonio Ospite
    http://ao2.it

    PGP public key ID: 0x4553B001

    A: Because it messes up the order in which people normally read text.
    See http://en.wikipedia.org/wiki/Posting_style
    Q: Why is top-posting such a bad thing?
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-06-01 21:57    [W:0.025 / U:29.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site