lkml.org 
[lkml]   [2011]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 3/5] dmaengine/dw_dmac: Divide one sg to many desc, if sg len is greater than DWC_MAX_COUNT
On 05/09/2011 11:41 AM, Koul, Vinod wrote:
> On Mon, 2011-05-09 at 12:03 +0530, viresh kumar wrote:
>> On 05/09/2011 11:17 AM, Koul, Vinod wrote:
>>> Ah, then there is another todo for this driver. Move from chan->private
>>> to DMA_SLAVE_CONFIG.
>>>
>>> struct dma_slave_config has dedicated fields for both source and
>>> destination widths, src_addr_width & dst_addr_width please use them...
>>> You should pass this structure to device control API as:
>>> dmaengine_device_control(
>>> chan, DMA_SLAVE_CONFIG, (unsigned long)&slave_config);
>>
>> As soon as i get some time, will study & implement this.
>> For now, please push this patchset (if it looks fine).
>>
> rest looks OK. Please fix the patch1.
>
>

I am resending all 5 patches, so that they get rebased cleanly.

--
viresh


\
 
 \ /
  Last update: 2011-05-09 10:19    [W:0.044 / U:1.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site