Messages in this thread | | | Date | Mon, 9 May 2011 10:00:02 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v3] leds: provide helper to register "leds-gpio" devices |
| |
Hello Richard,
On Fri, May 06, 2011 at 10:03:22PM +0100, Richard Purdie wrote: > On Wed, 2011-04-13 at 08:23 +0200, Uwe Kleine-König wrote: > > On Tue, Apr 12, 2011 at 10:48:48PM +0100, Russell King - ARM Linux wrote: > > > On Mon, Apr 11, 2011 at 10:35:57PM +0200, Uwe Kleine-König wrote: > > > > +obj-y += led-register.o > > > > > > Why not obj-$(CONFIG_LED_REGISTER_GPIO) += led-register.o > > > > > > rather than wrapping the code of led-register.c with a #ifdef for the > > > same symbol? > > I thought that the registration for other led-devices could go into that > > file, too. That's why I choosed the name led-register and not > > leds-gpio-register.c. Agreed? I don't insist on that. > > I'm not sure we want/need to put other registration functions in this > file? obj-$(CONFIG_LED_REGISTER_GPIO) probably therefore makes sense > until some other registration need arises. OK, then I will name the file leds-gpio-register.c. This can be renamed to led-register.c when/if other registrations follow.
> Regardless, I'm happier with this patch than the previous ones. If you > change it to use obj-$(CONFIG_LED_REGISTER_GPIO), > > Acked-by: Richard Purdie <richard.purdie@linuxfoundation.org> Who will take the patch then? Andrew? Or is there someone else I need to Cc?
Thanks Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |