lkml.org 
[lkml]   [2011]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 4/7] ext4: Clean up some wait_on_page_writeback calls
    From
    Date
    wait_on_page_writeback already checks the writeback bit, so callers of it
    needn't do that test.

    Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
    ---
    fs/ext4/inode.c | 4 +---
    fs/ext4/move_extent.c | 3 +--
    2 files changed, 2 insertions(+), 5 deletions(-)


    diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
    index f2fa5e8..3db34b2 100644
    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -2796,9 +2796,7 @@ static int write_cache_pages_da(struct address_space *mapping,
    continue;
    }

    - if (PageWriteback(page))
    - wait_on_page_writeback(page);
    -
    + wait_on_page_writeback(page);
    BUG_ON(PageWriteback(page));

    if (mpd->next_page != page->index)
    diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
    index b9f3e78..2b8304b 100644
    --- a/fs/ext4/move_extent.c
    +++ b/fs/ext4/move_extent.c
    @@ -876,8 +876,7 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode,
    * It needs to call wait_on_page_writeback() to wait for the
    * writeback of the page.
    */
    - if (PageWriteback(page))
    - wait_on_page_writeback(page);
    + wait_on_page_writeback(page);

    /* Release old bh and drop refs */
    try_to_release_page(page, 0);


    \
     
     \ /
      Last update: 2011-05-10 01:07    [W:0.021 / U:0.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site