Messages in this thread | | | Date | Mon, 9 May 2011 19:49:10 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH v9 7/7] usb: Adding SuperSpeed support to dummy_hcd |
| |
* Tatyana Brokhman | 2011-05-08 14:16:48 [+0300]:
> static int dummy_hcd_probe(struct platform_device *pdev) > { >- struct usb_hcd *hcd; >+ struct usb_hcd *hs_hcd; >+ struct usb_hcd *ss_hcd; > int retval; > > dev_info(&pdev->dev, "%s, driver " DRIVER_VERSION "\n", driver_desc); > >- hcd = usb_create_hcd(&dummy_hcd, &pdev->dev, dev_name(&pdev->dev)); >- if (!hcd) >+ hs_hcd = usb_create_hcd(&dummy_hcd, &pdev->dev, dev_name(&pdev->dev)); >+ if (!hs_hcd) > return -ENOMEM; >- the_controller = hcd_to_dummy (hcd); > >- retval = usb_add_hcd(hcd, 0, 0); >- if (retval != 0) { >- usb_put_hcd (hcd); >- the_controller = NULL; >+ hs_hcd->speed = HCD_USB2; Why do you overwrite the speed here and in ->reset()?
>+ >+ retval = usb_add_hcd(hs_hcd, 0, IRQF_DISABLED | IRQF_SHARED); Why IRQF_DISABLED | IRQF_SHARED? you don't interrupts at all.
>+ if (retval != 0) >+ usb_put_hcd(hs_hcd); Your error recovery is broken here. You have to leave instead of continue with SS.
>+ dev_set_drvdata(&pdev->dev, hs_hcd); This is already done by usb_add_hcd()
>+ >+ ss_hcd = usb_create_shared_hcd(&dummy_hcd, &pdev->dev, >+ dev_name(&pdev->dev), hs_hcd); >+ if (!ss_hcd) { >+ retval = -ENOMEM; >+ goto dealloc_usb2_hcd; > } >+ >+ retval = usb_add_hcd(ss_hcd, 0, IRQF_DISABLED | IRQF_SHARED); >+ if (retval) >+ goto put_usb3_hcd; >+ >+ return 0; >+ >+put_usb3_hcd: >+ usb_put_hcd(ss_hcd); >+dealloc_usb2_hcd: >+ usb_put_hcd(hs_hcd); >+ the_controller.hs_hcd = the_controller.ss_hcd = NULL; > return retval; > }
Sebastian
| |