Messages in this thread | | | Date | Sat, 7 May 2011 10:16:02 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/4] SCHED: Remove BKL accounting from schedstats |
| |
* Andi Kleen <andi@firstfloor.org> wrote:
> From: Andi Kleen <ak@linux.intel.com> > > Remove the BKL accounting from schedstats. > > I removed the field from the debug file too, in theory > it could be kept as 0 for compatibility. > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > include/linux/sched.h | 4 ---- > kernel/sched.c | 6 ------ > kernel/sched_debug.c | 3 --- > 3 files changed, 0 insertions(+), 13 deletions(-)
The thing is, and this is rather amazing: not a *single* patch in your patch series gets the patch title right ...
Andi, how hard is it for you to type 'git log kernel/sched.c' (and 'git log kernel/mutex.c', etc.) and see what the commit title convention the affected kernel subsystem has, and follow that convention, so that the maintainer does not have to edit every single patch of your series?
You are not a kernel newbie, you've been a kernel developer for how many years?
You are showing an amazing level of inattention, which makes me very reluctant to even look at your patches, all of which touch tricky pieces of code.
You badly need to improve the quality of your patches. You could start that by feeding patches to a third party who knows how to submit patches upstream and who can sign off to them and forward them to the right maintainers.
Thanks,
Ingo
| |