Messages in this thread | | | From | Changli Gao <> | Date | Sat, 7 May 2011 14:22:33 +0800 | Subject | Re: [PATCH] fs: add FD_CLOFORK and O_CLOFORK |
| |
On Sat, May 7, 2011 at 2:06 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Le samedi 07 mai 2011 à 12:49 +0800, Changli Gao a écrit : > >> >> for (i = open_files; i != 0; i--) { >> struct file *f = *old_fds++; >> if (f) { >> - get_file(f); >> + if (FD_ISSET(open_files - i, new_fdt->close_on_fork)) { >> + FD_CLR(open_files - i, new_fdt->open_fds); >> + f = NULL; >> + } else { >> + get_file(f); >> + } >> } else { >> /* > > You should change the main loop to > > for (i = 0; i < open_files; i++) { > struct file *f = *old_fds++; > > if (f && FD_ISSET(i, new_fdt->close_on_fork)) > f = NULL; > if (f) > get_file(f); > else > FD_CLR(i, new_fdt->open_fds) > rcu_assign_pointer(*new_fds++, f); > }
It seems more clear. Thanks.
BTW: I will work on F_CLOSFD after this patch accepted. It is useful to close all the opened file descriptors when programing a daemon.
-- Regards, Changli Gao(xiaosuo@gmail.com) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |