lkml.org 
[lkml]   [2011]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] blkdev: Do not return -EOPNOTSUPP if discard is supported
On 2011-05-05 09:12, Lukas Czerner wrote:
> Currently we return -EOPNOTSUPP in blkdev_issue_discard() if any of the
> bio fails due to underlying device not supporting discard request.
> However, if the device is for example dm device composed of devices
> which some of them support discard and some of them does not, it is ok
> for some bios to fail with EOPNOTSUPP, but it does not mean that discard
> is not supported at all.
>
> This commit removes the check for bios failed with EOPNOTSUPP and change
> blkdev_issue_discard() to return operation not supported if and only if
> the device does not actually supports it, not just part of the device as
> some bios might indicate.
>
> This change also fixes problem with BLKDISCARD ioctl() which now works
> correctly on such dm devices.

Applied, thanks.

--
Jens Axboe



\
 
 \ /
  Last update: 2011-05-07 03:33    [W:0.095 / U:0.284 seconds]
©2003-2014 Jasper Spaans. Advertise on this site