lkml.org 
[lkml]   [2011]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] coredump: use task comm instead of (unknown)
(Cc John)

On Fri, 6 May 2011 21:26:39 +0900
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:

> Andrew Morton wrote:
> > Direct access to current->comm is racy since we added
> > prctl(PR_SET_NAME).
>
> A passer-by's question. Did we change below one
>
> char *get_task_comm(char *buf, struct task_struct *tsk)
> {
> /* buf must be at least sizeof(tsk->comm) in size */
> task_lock(tsk);
> strncpy(buf, tsk->comm, sizeof(tsk->comm));
> task_unlock(tsk);
> return buf;
> }
>
> since some archs may do like
>
> char *strncpy(char *dest, const char *src, size_t n)
> {
> size_t len = __strnend(src, n) - src;
> __builtin_memset(dest + len, 0, n - len);
> __builtin_memcpy(dest, src, len);
> return dest;
> }
>
> ( arch/s390/lib/string.c ) after adding prctl(PR_SET_NAME)?

I don't understand what you're asking, sorry.


\
 
 \ /
  Last update: 2011-05-06 21:35    [from the cache]
©2003-2011 Jasper Spaans