lkml.org 
[lkml]   [2011]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig
Date


> -----Original Message-----
> From: H Hartley Sweeten [mailto:hartleys@visionengravers.com]
> Sent: Wednesday, May 04, 2011 2:44 PM
> To: KY Srinivasan; gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org
> Cc: Haiyang Zhang
> Subject: RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> Kconfig
>
> On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> >
> > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > Kconfig to reflect this.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > ---
> > drivers/staging/hv/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > index 76f0756..5e0c9f6 100644
> > --- a/drivers/staging/hv/Kconfig
> > +++ b/drivers/staging/hv/Kconfig
> > @@ -1,6 +1,6 @@
> > config HYPERV
> > tristate "Microsoft Hyper-V client drivers"
> > - depends on X86 && m
> > + depends on X86 && ACPI && PCI && m
> > default n
> > help
> > Select this option to run Linux as a Hyper-V client operating
>
> ACPI itself depends on PCI. It also depends on IA64 || X86. Will the
> vmbus driver work with IA64? If so the depends on could just be:
>
> depends on ACPI && m

Good point; vmbus will not work on IA64 though. So, minimally we would want
X86 && ACPI. I will resend this with this change.

Regards,

K. Y
>
> Also, default n is redudant since n is the default anyway.
>
> Regards,
> Hartley



\
 
 \ /
  Last update: 2011-05-04 20:51    [W:1.500 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site