lkml.org 
[lkml]   [2011]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [block IO crash] Re: 2.6.39-rc5-git2 boot crashs
On Wed, 4 May 2011, Ingo Molnar wrote:

>
> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > My gut reaction would be: let's do the minimal patch that just fixes things
> > to do irqsafe_cpu_cmpxchg_double() for 2.6.39, and then let's remove the
> > #ifdef'fery in -rc1. [...]
>
> Looks like the sanest option IMHO, -rc7 is pretty late for anything than a
> few-liner patch.

Agreed.

> > [...] Or make _really_ sure that things are ok for platforms that never even
> > triggered the CMPXCHG_LOCAL case before.
>
> Considering that the status quo was !CMPXCHG_LOCAL in v2.6.38 and that lockless
> SLUB is an x86-only affair right now:
>
> $ git grep CMPXCHG_LOCAL arch/
> arch/um/Kconfig.x86:config CMPXCHG_LOCAL
> arch/x86/Kconfig.cpu:config CMPXCHG_LOCAL
>
> There should be no problem with other architectures, right?

No, they use the local_irq disabled path which is pretty much the same
as in 38.

Thanks,

tglx


\
 
 \ /
  Last update: 2011-05-04 19:15    [from the cache]
©2003-2011 Jasper Spaans