lkml.org 
[lkml]   [2011]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [block IO crash] Re: 2.6.39-rc5-git2 boot crashs

* Christoph Lameter <cl@linux.com> wrote:

> On Wed, 4 May 2011, Tejun Heo wrote:
>
> > The cmpxchg_double optimization made the fast path go quite faster
> > when CPU supports it but it may as well slow things down considerably
> > if CPU doesn't, due to extra irq on/off's. Anyways, here's hoping
> > that the slow down is acceptable compared to the base code without
> > cmpxchg_double and the ugliness can be removed.
>
> I think we are all in agreement. First path to fix the percpu macros:
>
>
> Subject: percpu: Fix irqsafe_cpu_cmpxchg_double
>
> The function in the macro was not updated when the function was given a bool return value.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>

Note, the final commit needs to have a proper Reported-by and explanation about
how this was triggered, to fairly credit all the hard work done by Werner ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-04 17:23    [W:0.455 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site