Messages in this thread | | | Date | Wed, 4 May 2011 19:02:34 +0400 | From | Anton Vorontsov <> | Subject | Re: [PATCHv3 0/7] gpio: extend basic_mmio_gpio for different controllers |
| |
On Wed, May 04, 2011 at 03:37:57PM +0100, Jamie Iles wrote: [...] > + err = bgpio_init(bgc, dev, sz, dat, set, clr, dirout, dirin, be); > + if (err) > + return err; > + > + if (pdata) { > + bgc->gc.base = pdata->base; > + if (pdata->ngpio > 0) > + bgc->gc.ngpio = pdata->ngpio; > + } > + > + platform_set_drvdata(pdev, bgc); > + > + return 0;
return gpio_chip_add(&bgc->gc)? Or bgpio_chip_add(bgc);
Otherwise this looks great. Feel free to add my
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Thanks!
-- Anton Vorontsov Email: cbouatmailru@gmail.com
| |