lkml.org 
[lkml]   [2011]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] writeback: introduce writeback_control.inodes_cleaned
On Wed, May 04, 2011 at 07:11:30PM +0800, Wu Fengguang wrote:
> On Wed, May 04, 2011 at 07:05:00PM +0800, Christoph Hellwig wrote:
> > Same here - this has nothing to do with actual page writeback and really
> > should stay internal to fs/fs-writeback.c
>
> OK, I'll check how to constrain writeback_control to the minimal scope.

The basic idea would be to pass the struct wb_writeback_work all the
way down to writeback_sb_inodes, and initialize the struct writeback_control
there. This requires adding a few more fields like more_io and
older_than_this to struct wb_writeback_work, and redoing a lot of the
tracing, but it immediately clean things up, e.g. suddently
wbc.nr_to_write vs work->nr_pages starts to make sense, and instead
of saving and restoring pages_skipped in writeback_sb_inodes it can
always start with a clean zero value.



\
 
 \ /
  Last update: 2011-05-04 13:19    [W:0.120 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site