lkml.org 
[lkml]   [2011]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] gpio: gpio-mxc: add gpio driver for Freescale MXC architecture
    Hi Shawn,

    On Mon, May 30, 2011 at 10:52:16PM +0800, Shawn Guo wrote:
    > Add gpio-mxc driver by copying arch/arm/plat-mxc/gpio.c into
    > drivers/gpio with the following changes.
    >
    > * Use readl/writel to replace mach-specific accessors
    > __raw_readl/__raw_writel
    >
    > * Migrate to platform driver by adding .probe function
    >
    > * Add a list to save all mx2 ports references, so that
    > mx2_gpio_irq_handler can walk through all interrupt status
    > registers
    >
    > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
    > ---

    Could you use the stuff in drivers/gpio/basic_mmio_gpio.c for
    implementing the gpio_chip? I had a go a little while ago [1] but since
    then we've made it possible to embed the bgpio_chip in your own
    structure which may be cleaner.

    Jamie

    1. http://permalink.gmane.org/gmane.linux.ports.arm.kernel/113139


    \
     
     \ /
      Last update: 2011-05-31 10:47    [W:0.018 / U:90.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site