Messages in this thread | | | Date | Tue, 31 May 2011 19:02:54 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] AppArmor: fix oops in apparmor_setprocattr |
| |
Hi James,
On Wed, Jun 01, 2011 at 10:25:37AM +1000, James Morris wrote: > On Tue, 31 May 2011, Kees Cook wrote: > > When invalid parameters are passed to apparmor_setprocattr a NULL deref > > oops occurs when it tries to record an audit message. This is because > > it is passing NULL for the profile parameter for aa_audit. But aa_audit > > now requires that the profile passed is not NULL. > > > > Fix this by passing the current profile on the task that is trying to > > setprocattr. > > Is this trigger able by unprivileged users?
Yes, but the Oops kills the process doing the write as it triggers the BUG_ON, not the process being written to.
> >From which upstream commit is this an issue?
b5e95b48685e3481139a5634d14d630d12c7d5ce
-Kees
-- Kees Cook Ubuntu Security Team
| |