lkml.org 
[lkml]   [2011]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ftrace: tracepoint of net_dev_xmit sees freed skb and causes panic
FromSteven Rostedt <>
DateTue, 31 May 2011 12:21:30 -0400
On Tue, 2011-05-31 at 12:11 -0400, Neil Horman wrote:
> skb_dst_drop(nskb);
> > >
> > > + skb_len = nskb->len;
> > > rc = ops->ndo_start_xmit(nskb, dev);
> > > - trace_net_dev_xmit(nskb, rc);
> > > + trace_net_dev_xmit(nskb, rc, dev, skb_len);
> >
> > What if you just put the tracepoint before the call to
> > ops->ndo_start_xmit?
> >
> Then you won't know the return code of ndo_start_xmit, which this tracepoint
> records.

Doh! Yeah, I see that now ;)

-- Steve




\
 
 \ /
  Last update: 2011-05-31 19:57    [from the cache]
©2003-2010