lkml.org 
[lkml]   [2011]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 14/14] tmpfs: no need to use i_lock
From
Date
On Mon, 2011-05-30 at 17:55 -0700, Hugh Dickins wrote:
> 2.6.36's 7e496299d4d2 to make tmpfs scalable with percpu_counter used
> inode->i_lock in place of sbinfo->stat_lock around i_blocks updates;
> but that was adverse to scalability, and unnecessary, since info->lock
> is already held there in the fast paths.
>
> Remove those uses of i_lock, and add info->lock in the three error
> paths where it's then needed across shmem_free_blocks(). It's not
> actually needed across shmem_unacct_blocks(), but they're so often
> paired that it looks wrong to split them apart.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> Cc: Tim Chen <tim.c.chen@linux.intel.com>
> ---

Acked.

Tim Chen





\
 
 \ /
  Last update: 2011-05-31 18:13    [W:0.199 / U:0.356 seconds]
©2003-2014 Jasper Spaans. Advertise on this site