Messages in this thread | | | Date | Tue, 31 May 2011 15:14:14 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 2/3] block: Move non-rotational flag to queue limits |
| |
On 2011-05-31 04:19, Martin K. Petersen wrote: > - queue_flag_set_unlocked(QUEUE_FLAG_NONROT, disk->queue); > + blk_queue_non_rotational(queue);
I don't like this part of the change. Before it was immediately apparently that we were setting this flag, know you have no idea what it does. Please make that blk_queue_set_non_rotational().
Otherwise looks fine.
-- Jens Axboe
| |