Messages in this thread | | | Date | Tue, 31 May 2011 12:47:02 +0200 | From | Michał Mirosław <> | Subject | Re: [PATCH v4] 8250_pci: add -ENODEV code for Intel EG20T PCH |
| |
On Tue, May 31, 2011 at 07:35:30PM +0900, Tomoya MORINAGA wrote: > Intel EG20T PCH has UART device which is compatible with 8250. > Currently, with general configuration, the PCH UART driver is not loaded but > 8250 standard driver is loaded. > Therefore, in case of using PCH UART driver, need to disable 8250 pci function. > However, this procedure is not best solution. > This patch, in 8250_pci, if the device is the PCH or the family IOH, > '-ENODEV' is returned. > As a result, disabling 8250-pci processing becomes unnecessary. [...]
My comment about return_ENODEV() name does not make sense if you put the ifdef inside that function. I thought you would put it around the device-id entries.
Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |