lkml.org 
[lkml]   [2011]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] oprofile fixes for v2.6.40

* Robert Richter <robert.richter@amd.com> wrote:

> > But i really do not see how this can work. get_eilvt() twiddles
> > the APIC LVT of this current CPU. Does IBS only activate on a
> > single CPU? How will this LVT entry be cleared on deinit?
>
> This is done on the current cpu to get the offset which is then
> used on all cpus of the system. The actually per-core setup for ibs
> is in op_amd_setup_ctrs(). Deinit is in op_amd_cpu_shutdown().

The way IBS is set up is not very obvious and atypical of existing
preempt_*() patters. Might be worth adding a comment to the
preempt_disable(), to unconfuse unsuspecting readers who are
wondering about its oddness?

Anyway, i suspected that it was correctly working code so i pulled it
and pushed it to Linus, it should all be in 3.0-rc1.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-30 12:13    [W:0.060 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site