lkml.org 
[lkml]   [2011]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm, vmstat: Use cond_resched only when !CONFIG_PREEMPT
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 20c18b7..72cf857 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -461,7 +461,11 @@ void refresh_cpu_vm_stats(int cpu)
> p->expire = 3;
> #endif
> }
> +
> +#ifndef CONFIG_PREEMPT
> cond_resched();
> +#endif
> +

In general, we should avoid #ifdef CONFIG_PREEMPT for maintainancebility as far as possible.
Is there any observable benefit? Can you please demonstrate it?





\
 
 \ /
  Last update: 2011-05-31 04:25    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site