Messages in this thread | | | From | Mike Frysinger <> | Date | Mon, 30 May 2011 18:54:04 -0400 | Subject | Re: [PATCH] ptrace: unify show_regs() prototype |
| |
On Mon, May 30, 2011 at 15:07, Oleg Nesterov wrote: > On 05/29, Mike Frysinger wrote: >> --- a/include/linux/ptrace.h >> +++ b/include/linux/ptrace.h >> +extern void show_regs(struct pt_regs *); > > Not sure ptrace.h is the right place. show_regs() has the callers which > have nothing to do with ptrace.
it needs pt_regs and everyone puts it in their own ptrace.h, so linux/ptrace.h was the logical common place for it
> Hmm. You know what? show_regs() is already defined in sched.h, probably > you can simply remove this chunk.
nice, i hadnt noticed. i'll send a new version. -mike
| |