Messages in this thread | | | Date | Mon, 30 May 2011 21:07:13 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] ptrace: unify show_regs() prototype |
| |
On 05/29, Mike Frysinger wrote: > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > --- > andrew: can you pick this up ? sent a few months ago w/no love.
The patch looks obviously fine, I can put it into ptrace tree.
Cough. Yes it is simple, but perhaps it still needs the changelog? Even a single line.
One nit,
> --- a/include/linux/ptrace.h > +++ b/include/linux/ptrace.h > @@ -100,6 +100,7 @@ > #include <linux/sched.h> /* For struct task_struct. */ > > > +extern void show_regs(struct pt_regs *);
Not sure ptrace.h is the right place. show_regs() has the callers which have nothing to do with ptrace.
Hmm. You know what? show_regs() is already defined in sched.h, probably you can simply remove this chunk.
Oleg.
| |