lkml.org 
[lkml]   [2011]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/12] x86, mce: introduce mce_gather_info()
    (2011/05/28 1:29), Tony Luck wrote:
    > On Fri, May 27, 2011 at 1:00 AM, Ingo Molnar <mingo@elte.hu> wrote:
    >> At minimum an explanation should be put into the code. Small, hidden
    >> dependencies might be common job security moves in the closed source
    >> world but this is open source ;-)
    >
    > Seto-san,
    >
    > Perhaps this more descriptive comment for you new mce_gather_info()
    > function would help:
    >
    > /*
    > * Collect all global (w.r.t. this processor) status about this machine
    > * check into our "mce" struct so that we can use it later to assess
    > * the severity of the problem as we read per-bank specific details.
    > */

    Thank you very much!
    I'll update my patch to have this comment.

    Thanks,
    H.Seto



    \
     
     \ /
      Last update: 2011-05-30 07:45    [W:0.028 / U:31.460 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site