Messages in this thread | | | Date | Mon, 30 May 2011 14:42:30 +0900 | From | Hidetoshi Seto <> | Subject | Re: [PATCH 07/12] x86, mce: introduce mce_gather_info() |
| |
(2011/05/28 1:29), Tony Luck wrote: > On Fri, May 27, 2011 at 1:00 AM, Ingo Molnar <mingo@elte.hu> wrote: >> At minimum an explanation should be put into the code. Small, hidden >> dependencies might be common job security moves in the closed source >> world but this is open source ;-) > > Seto-san, > > Perhaps this more descriptive comment for you new mce_gather_info() > function would help: > > /* > * Collect all global (w.r.t. this processor) status about this machine > * check into our "mce" struct so that we can use it later to assess > * the severity of the problem as we read per-bank specific details. > */
Thank you very much! I'll update my patch to have this comment.
Thanks, H.Seto
| |