Messages in this thread | | | Date | Tue, 3 May 2011 16:57:15 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [Stable-review] [36/55] [PARISC] slub: fix panic with DISCONTIGMEM |
| |
On Wed, 4 May 2011, Ben Hutchings wrote:
> > SLUB relies heavily on N_NORMAL_MEMORY, so these two patches fix that > > allocator but the problem is actually not just isolated to that subsystem; > > it fixes an issue with anything that uses N_NORMAL_MEMORY. > > > > The former patch sets the nodes correctly for parisc and Michael's patch > > sets the nodes correctly for m68k, so it's the same fix for two different > > previously-broken architectures. > > So if I understand you correctly, the Kconfig condition for SLUB is > now wrong - only architectures that use DISCONTIGMEM's fake-NUMA and > don't set the node states to N_NORMAL_MEMORY will break it. And > there's no good way to test for that in Kconfig. >
Right, I haven't seen a kernel panic from a kernel that still breaks after those two patches (the one for parisc and the one for m68k) were merged in the slub allocator. James, if you have such a panic on parisc, please post it.
Thanks!
| |