lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] perf: Add persistent event facilities

* Borislav Petkov <bp@amd64.org> wrote:

> > we could move the other perf_events.c facilities there as well, and maybe
> > split up the file a bit, it's 7.5 KLOC now which is a bit excessive.
>
> Right, so I left perf_event.c as a whole on purpose (only renamed) because it
> makes more sense IMHO for someone who actually wrote it to split it in
> logical parts (^hint hint^). I mean, I could do it too but it'll take me much
> more time :).

Well you are now writing new events code as well so spending that time might be
a good investment in terms of getting persistent.c right as well.

Could you send a Git pull request against perf/core that does the obvious file
movement and renaming? We can do that first step straight away and get the ball
rolling.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-03 10:25    [W:0.069 / U:0.212 seconds]
©2003-2014 Jasper Spaans. Advertise on this site