lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] usbnet: Style cleanups
    Date
    Am Dienstag, 3. Mai 2011, 20:17:57 schrieb Joe Perches:
    > drivers/net/usb/usbnet.c | 625 +++++++++++++++++++++++----------------------
    > 1 files changed, 319 insertions(+), 306 deletions(-)
    >
    > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
    > index 7bc9852..28aecbb 100644
    > --- a/drivers/net/usb/usbnet.c
    > +++ b/drivers/net/usb/usbnet.c
    > @@ -30,8 +30,8 @@
    > * issues can usefully be addressed by this framework.
    > */
    >
    > -// #define DEBUG // error path messages, extra info
    > -// #define VERBOSE // more; success messages
    > +/* #define DEBUG // error path messages, extra info */
    > +/* #define VERBOSE // more; success messages */

    Hi,

    1. please don't touch things like that. They are not comments in a semantic sense
    2. If you are touching comments, please redo the multiline comments according to
    the coding style.
    3. please delay these modifications until the patches against the oom problem have
    been applied

    Regards
    Oliver

    --
    - - -
    SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
    Maxfeldstraße 5
    90409 Nürnberg
    Germany
    - - -
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-05-03 20:51    [W:0.023 / U:347.952 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site