Messages in this thread | | | Date | Tue, 3 May 2011 10:33:09 -0700 | From | Greg KH <> | Subject | Re: [PATCH] staging: hv: make HYPERV_UTILS depend on NLS to prevent a build error |
| |
On Mon, Apr 25, 2011 at 08:53:26PM -0400, Peter Foley wrote: > On 4/25/2011 8:00 PM, Greg KH wrote: > > On Mon, Apr 25, 2011 at 07:52:18PM -0400, Peter Foley wrote: > >> This patch adds a dependency on NLS to HYPERV_UTILS to avoid a build error. > > > > What is the build error? > > > > thanks, > > > > greg k-h > > > When CONFIG_HYPERV_UTILS=y and CONFIG_NLS=n > the build fails with this error: > > Building modules, stage 2. > MODPOST 3 modules > ERROR: "utf8s_to_utf16s" [drivers/staging/hv/hv_utils.ko] undefined! > make[3]: *** [__modpost] Error 1 > make[2]: *** [modules] Error 2 > make[2]: *** Waiting for unfinished jobs.... > Kernel: arch/x86/boot/bzImage is ready (#2) > make[1]: *** [sub-make] Error 2 > make: *** [all] Error 2
Ah, ok, we need this for that function, that's what I wanted to know, I'll put it in the changelog entry. Please do that the next time.
thanks,
greg k-h
| |